Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #29

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Develop #29

wants to merge 4 commits into from

Conversation

ariel-compie
Copy link

Added support for creating multiple swagger json for api versioning

@pesoklp13
Copy link

Hi, can i ask you about the purpose of this pull request? (as you can see i already created fork of this project and added tag support from @moosi in it, but really do not understand the meaning of yours.

I will try to explain how i understand it. You wanna have more then one versions of API deployed in parallel and defined it only by different decorators?

So my question is, how will you solve the problem of the interface changes? For example you will need to change whole model (do it more complex or remove some currently required property - do not say you will make it optional it is balast!)? How will you solve the need of different path configuration for each version?

If you need it just for generating another swagger definition it is not worth your time i think.

After all. Why did you add apiVersion to ISwaggerExpressOptions? You have information about the api version from ISwaggerBuildDefinition.info, when you creating router no need to extend ISwaggerExpressOptions.

And what is really missing are tests! Without it i can just hope i can imagine what is the real purpose of this pull request. If you send me more information i would like to change my mind if am wrong and be glad to add it to my fork.

Copy link

@mariomurrent-softwaresolutions mariomurrent-softwaresolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the formatting - seems like you are using a different formatter.
Otherwise it is hard to track the actual changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants